-
-
Notifications
You must be signed in to change notification settings - Fork 384
chore(defaults): Applies latest webpack-defaults #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Migrates to CircleCI 2.0 from Travis - Removes Appveyor by default ( can be opted into ) - Uses a non-deprecated form of eslit config - Adds base codecov config - Adds commitlint config / hook - Updates PR templates & adds Codeowners - Prettier tooling & complementary eslit config added
- Updates engines range to disclude nodejs 7 ( we test on 9.x ) - Moves to scoped version of eslint config w/ prettier support - Moves to scoped version of schema-utils with pretty output - Adds commit message validation scripts - Update CI related scripts for CircleCI 2.0
- Implements workflow on custom build containers - Fails fast on static analysis or minimum node version test failure - Executes canary suite ( or doesn't ) based on semver comparison of Webpack dist-tags
- Tobias didn't want his picture in there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A minor issue.
package.json
Outdated
"security": "nsp check", | ||
"test": "jest", | ||
"test:watch": "jest --watch", | ||
"test:coverage": "jest --collectCoverageFrom='src/**/*.js' --coverage", | ||
"test:manual": "webpack-dev-server test/manual/src/index.js --open --config test/manual/webpack.config.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script should be kept
- Switches from Angular to Conventional commit config - Adds Contributing documentation ( w/ commit conventions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Merge at your will.
Updates applied as a part of the upgrade from
webpack-defaults 1.6 => 2.2
General Boilerplate (04d9a02)
package.json meta (12191e9)
Continuous Integration (94365da)
Branch / Fork build workflow
Master build workflow
Prettier (629ef38)
.prettierrc
Note: I will update the eslint configurations enforcement of
class-methods-use-this
. I'm pretty sure we override that in every one of the contrib libs.