Skip to content

chore(defaults): Applies latest webpack-defaults #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 7, 2018

Conversation

joshwiens
Copy link
Member

@joshwiens joshwiens commented Apr 3, 2018

Updates applied as a part of the upgrade from webpack-defaults 1.6 => 2.2

General Boilerplate (04d9a02)

  • Migrates to CircleCI 2.0 from Travis
  • Removes Appveyor by default ( can be opted into )
  • Uses a non-deprecated form of eslit config
  • Adds base codecov config
  • Adds commitlint config / hook
  • Updates PR templates & adds Codeowners
  • Prettier tooling & complementary eslint config added

package.json meta (12191e9)

  • Updates engines range to disclude nodejs 7 ( we test on 9.x )
  • Moves to scoped version of eslint config w/ prettier support
  • Moves to scoped version of schema-utils with pretty output
  • Adds commit message validation scripts
  • Update CI related scripts for CircleCI 2.0

Continuous Integration (94365da)

  • Implements workflow on custom build containers
  • Fails fast on static analysis or minimum node version test failure
  • Executes canary suite ( or doesn't ) based on semver comparison of Webpack dist-tags
  • Fail fast approach running static analysis & unit tests against the minimum supported node version w/ webpack@latest, fanning out to cover the remaining matrix if those two steps pass.
Branch / Fork build workflow

screen shot 2018-04-03 at 5 32 57 am

Master build workflow

fullbuild-workflow

Prettier (629ef38)

  • Applies Prettier style updates ( right click & format with prettier plugin for VSCode / Atom ) will read from the .prettierrc

Note: I will update the eslint configurations enforcement of class-methods-use-this. I'm pretty sure we override that in every one of the contrib libs.

 - Migrates to CircleCI 2.0 from Travis
 - Removes Appveyor by default ( can be opted into )
 - Uses a non-deprecated form of eslit config
 - Adds base codecov config
 - Adds commitlint config / hook
 - Updates PR templates & adds Codeowners
 - Prettier tooling & complementary eslit config added
 - Updates engines range to disclude nodejs 7 ( we test on 9.x )
 - Moves to scoped version of eslint config w/ prettier support
 - Moves to scoped version of schema-utils with pretty output
 - Adds commit message validation scripts
 - Update CI related scripts for CircleCI 2.0
 - Implements workflow on custom build containers
 - Fails fast on static analysis or minimum node version test failure
 - Executes canary suite ( or doesn't ) based on semver comparison of Webpack dist-tags
 - Tobias didn't want his picture in there
@joshwiens joshwiens changed the title [WIP] chore(defaults): Applies latest webpack-defaults chore(defaults): Applies latest webpack-defaults Apr 3, 2018
@joshwiens joshwiens requested a review from sokra April 3, 2018 10:38
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A minor issue.

package.json Outdated
"security": "nsp check",
"test": "jest",
"test:watch": "jest --watch",
"test:coverage": "jest --collectCoverageFrom='src/**/*.js' --coverage",
"test:manual": "webpack-dev-server test/manual/src/index.js --open --config test/manual/webpack.config.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script should be kept

 - Switches from Angular to Conventional commit config
 - Adds Contributing documentation ( w/ commit conventions)
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Merge at your will.

@joshwiens joshwiens merged commit 2709413 into master May 7, 2018
@joshwiens joshwiens deleted the d3viant0ne/ci/CircleSwap branch May 7, 2018 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants